Fix shutdown #107
Open
Fix shutdown #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `-r` flag from the `shutdown` command
|
Agree on this, it's a copy-paste mistake. I read through all the code and was confused about this line. |
|
why hasnt this been merged? @cgherman |
@RetroFlag can you please work on merging this for customers? It seems like an easy fix to verify, and there are several people in agreement on this... |
|
SafeShutdown.py里面的 poweroff 函数里面的os.system(’shutdown -r now') 是重启，你应该改成 os.system('shutdown -h now') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90 .
Right now the shutdown command is using the
-rflag, which, when used, actually reboots a system. The correct command should be without that flag. Seeman 8 shutdown.